Add missing branding checks #1995
Conversation
|
I don't think the brand checks in the Looks like some of the legacy tests will need to be adjusted or deleted, and we should add the failing test262 tests to the expected failure list (at least, until we get another test262 PR merged to update the test262 tests upstream.) |
jessealama
force-pushed
the
ensure-requireinternal-slot
branch
from
02406c4 to
9f0fdb1
Compare
|
OK I restored the branding tests that I thought were ill-conceived. |
Codecov Report
@@ Coverage Diff @@
## main #1995 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 19 19
Lines 11006 11011 +5
Branches 1599 1614 +15
=======================================
+ Hits 10401 10406 +5
Misses 585 585
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jessealama
force-pushed
the
ensure-requireinternal-slot
branch
from
8ce7a2d to
9f0fdb1
Compare
|
I started writing tests at https://github.com/tc39/test262/compare/main...Igalia:branding?expand=1, but it seems like some existing ones need changes as well, like |
|
Yeah, looks like we will need to add expected failures for those tests until we can get the fix merged into test262. |
References: + tc39#1693
New branding checks for `TimeZone` invalidate the assumption underlying this test.
ptomato
force-pushed
the
ensure-requireinternal-slot
branch
from
f9aa872 to
016f8fa
Compare
toJSON. Reject '-000000' as an extended year value. Bump test262. Port of tc39/proposal-temporal#1995. Port of tc39/proposal-temporal#1992
3 participants
References: