Remove zoneRequired option in ParseTemporalTimeZoneString & better align parsing to spec
#1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingrant
added
non-prod-polyfill
Codecov Report
@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 94.98% 94.99% +0.01%
==========================================
Files 19 19
Lines 10943 10939 -4
Branches 1739 1739
==========================================
- Hits 10394 10392 -2
+ Misses 533 531 -2
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ptomato
approved these changes
Dec 14, 2021
polyfill/lib/ecmascript.mjs
Outdated
| ParseTemporalInstantString: (isoString) => { | ||
| return ES.ParseISODateTime(isoString, { zoneRequired: true }); | ||
| const result = ES.ParseISODateTime(isoString); | ||
| if (!result || (!result.z && !result.offset)) throw new RangeError('Temporal.Instant requires a time zone offset'); |
There was a problem hiding this comment.
Do we need !result here? It seems like an object will always be returned. (Same comment goes for ParseTemporalZonedDateTimeString below)
There was a problem hiding this comment.
Whoops, must have been left over from a previous go at solving this problem with the same "return false" pattern that we're actually removing. I'll remove and then merge.
The `zoneRequired` option in ParseTemporalTimeZoneString doesn't work, because the `zonesplit` regex in regex.mjs matches any string. (It does correctly match each component, it just doesn't fail if none match.) Furthermore, callers of this option don't really follow the spec that requires throwing as soon as we know that it's not the right regex for the type. This commit fixes tc39#1973 by: * Removing the `zoneRequired` option * Removing the now-unused `datetime` regex, and renaming the `instant` regex to `zoneddatetime` to better reflect what it's doing. * Refactoring a few of the parsing methods to better match the spec, which expects that strings that don't satisfy the production will throw before doing non-parsing work. After this commit, every `Parse*` method will throw if the string doesn't match the production for that type.
justingrant
force-pushed
the
remove-zone-required-option
branch
from
050aa56 to
9fafb23
Compare
justingrant
added a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Dec 15, 2021
justingrant
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zoneRequiredoption inES.ParseTemporalTimeZoneStringdoesn't work, because thezonesplitregex in regex.mjs matches any string. (It does correctly match each component, it just doesn't fail if none match.) Furthermore, callers of this option don't really follow the spec that requires throwing as soon as we know that it's not the right regex for the type.This PR fixes #1973 by:
zoneRequiredoptiondatetimeregex, and renaming theinstantregex tozoneddatetimeto better reflect what it's doing.Parse*AO will throw if the string doesn't match the production for that type.