Editorial: Move calendar validation out of ParseTemporalCalendarString #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @FrankYFTang |
Codecov Report
@@ Coverage Diff @@
## main #1954 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 19 19
Lines 10949 10949
Branches 1739 1739
=======================================
Hits 10402 10402
Misses 531 531
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Ms2ger
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1897, we want to move any validation that is not purely syntactic out of ParseTemporal___String abstract operations. This accomplishes that for Calendar. However, it affects nothing observable, just reorganizes code.
Closes: #1901