Normative: Use internal slot in UnbalanceDurationRelative. #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
added
the
needs plenary input
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
==========================================
- Coverage 95.10% 94.82% -0.29%
==========================================
Files 19 19
Lines 10764 10761 -3
Branches 1725 1725
==========================================
- Hits 10237 10204 -33
- Misses 514 544 +30
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ptomato
approved these changes
Jul 6, 2021
Since the step 4 stement in CalendarDateUntil is 4. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]). _untilResult_ is guarantee to be a TemporalDuration object and there are no need to call Get - which could return any kind of values, but only need to acecss [[Months]] which is guarantee for certain type and range.
ptomato
force-pushed
the
various-normative
branch
from
3d92ef9 to
ca050fd
Compare
|
I've added Frank's additional fixes from #1673 here, to consolidate the two pull requests, and added test coverage for each entry point where this happens. |
|
thanks |
|
This change achieved consensus in TC39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.