ISOMonthDayFromFields: Reject leap day in appropriate cases when calendar is specified. #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1395 +/- ##
===========================================
- Coverage 95.37% 48.30% -47.08%
===========================================
Files 19 18 -1
Lines 11154 5010 -6144
Branches 1832 1113 -719
===========================================
- Hits 10638 2420 -8218
- Misses 511 2156 +1645
- Partials 5 434 +429
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ndar is specified. ToTemporalMonthDay accepts 'month' without 'monthCode' or 'year' when no calendar has been specified, for users writing calendar-insensitive code. However, when a calendar has been specified, ISOMonthDayFromFields will still accept 2/29/2001 specified via month and year. This change makes ISOMonthDayFromFields reject or constrain 02-29 when month + year are specified, and keeps acceptance of 02-29 when only monthCode + day are specified. See the added test case for some examples.
ptomato
approved these changes
Feb 26, 2021
cjtenny
added a commit
that referenced
this pull request
Feb 27, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear.
cjtenny
added a commit
that referenced
this pull request
Feb 27, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 8, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 13, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 13, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 13, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToTemporalMonthDay accepts 'month' without 'monthCode' or 'year' when no calendar has been specified, for users writing calendar-insensitive code. However, when a calendar has been specified, ISOMonthDayFromFields will still accept 2/29/2001 specified via month and year. This change makes ISOMonthDayFromFields reject or constrain 02-29 when month + year are specified, and keeps acceptance of 02-29 when only monthCode + day are specified. See the added test case for some examples.