Don't convert custom calendar fields to integers #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the built-in fields (year through nanosecond, and the plural names for Duration) should be converted to integers. Custom calendar fields should not have any type conversion performed on them. Closes: #1045
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042,
mattjohnsonpint and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 94.29% 94.33% +0.04%
==========================================
Files 18 18
Lines 6675 6694 +19
Branches 999 1000 +1
==========================================
+ Hits 6294 6315 +21
+ Misses 374 372 -2
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ms2ger
approved these changes
Oct 26, 2020
Comment on lines
+63
to
+83
| const BUILTIN_FIELDS = new Set([ | ||
| 'year', | ||
| 'month', | ||
| 'day', | ||
| 'hour', | ||
| 'minute', | ||
| 'second', | ||
| 'millisecond', | ||
| 'microsecond', | ||
| 'nanosecond', | ||
| 'years', | ||
| 'months', | ||
| 'weeks', | ||
| 'days', | ||
| 'hours', | ||
| 'minutes', | ||
| 'seconds', | ||
| 'milliseconds', | ||
| 'microseconds', | ||
| 'nanoseconds' | ||
| ]); |
There was a problem hiding this comment.
Edge case for followup: this doesn't match the spec if calendar.fields returns one of the builtin fields that don't apply to the object in question.
There was a problem hiding this comment.
I added this question to #1047 for followup, as it seems very similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the built-in fields (year through nanosecond, and the plural names
for Duration) should be converted to integers. Custom calendar fields
should not have any type conversion performed on them.
Closes: #1045