Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need spec changes for "M" prefix on monthCode #1348

Closed
justingrant opened this issue Feb 4, 2021 · 3 comments · Fixed by #1362
Closed

Need spec changes for "M" prefix on monthCode #1348

justingrant opened this issue Feb 4, 2021 · 3 comments · Fixed by #1362
Assignees
Labels
spec-text Specification text involved
Milestone

Comments

@justingrant
Copy link
Collaborator

#1341 (adding "M" prefix to monthCode) didn't contain any spec changes because I didn't know how to document string concatenation or splitting in spec language. Could someone who is better at spec-ese than I am take a crack at it?

@cjtenny
Copy link
Collaborator

cjtenny commented Feb 4, 2021

After the meeting tomorrow I'll knock it out for temporal, since temporal AFAIK should only contain the ISO month code specs - quite quick!

@ptomato ptomato added the spec-text Specification text involved label Feb 8, 2021
@ptomato ptomato added this to the Stage 3 milestone Feb 8, 2021
@justingrant
Copy link
Collaborator Author

Following up from #1245 (comment), we may want to include the one-line spec change to ToTemporalMonthDay (3.j.i) in the fix to this issue.

@cjtenny
Copy link
Collaborator

cjtenny commented Feb 11, 2021

I have commits for both of those and other issues that I've been scared to push lest they be perceived as API changes. I asked a few people for feedback and the suggestion was to push them separately and highlight that they're small & not {bugfixes, to-be-standardized but not-262, etc}.

cjtenny added a commit that referenced this issue Feb 11, 2021
This is subject to further change based on IETF standardization of monthCodes; it is not going to be defined by temporal.

Fixes #1348.
cjtenny added a commit that referenced this issue Feb 11, 2021
This is subject to further change based on IETF standardization of monthCodes; it is not going to be defined by temporal.

Fixes #1348.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-text Specification text involved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants