Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Advance to Stage 3 #24

Closed
9 tasks done
mathiasbynens opened this issue May 26, 2021 · 10 comments
Closed
9 tasks done

Advance to Stage 3 #24

mathiasbynens opened this issue May 26, 2021 · 10 comments
Labels

Comments

@mathiasbynens
Copy link
Member

mathiasbynens commented May 26, 2021

Criteria taken from the TC39 process document minus those from previous stages:

  • Complete spec text

https://github.com/tc39/proposal-regexp-set-notation#specification

  • Designated reviewers have signed off on the current spec text
  • All ECMAScript editors have signed off on the current spec text
@markusicu
Copy link
Collaborator

markusicu commented Nov 17, 2021

Dear stage 3 reviewers @waldemarhorwat @gibson042 @msaboff -- We have the spec text in the regular format (thanks to @FrankYFTang): https://github.com/tc39/proposal-regexp-set-notation#specification

Please review, and let us know if you find bugs, problems, things that are unclear.

There are still some sections with yellow background; it would be useful if we could take some of them into the final spec, to add explanations and clarifications, like code comments in programming languages. Can we use NOTEs for them, or just prose nearby?

@mathiasbynens

This comment has been minimized.

@mathiasbynens
Copy link
Member Author

@waldemarhorwat, @gibson042, @msaboff, our spec PR has already gone through a few rounds of editorial review. Now would be a great time to start your Stage 3 reviews: tc39/ecma262#2418

@markusicu
Copy link
Collaborator

@waldemarhorwat, @gibson042, @msaboff, could you please take a look at our proposed changes and let us know if there are blockers for advancing to stage 3?

@markusicu
Copy link
Collaborator

FYI @waldemarhorwat has provided his stage 3 review feedback in issue #54. @mathiasbynens and I have addressed the issues there, with one new PR still pending right now.

@gibson042
Copy link

Review done at tc39/ecma262#2418 (review) , some nits and one or two substantial questions but nothing that looks like a Stage 3 blocker.

mathiasbynens added a commit that referenced this issue Mar 29, 2022
@mathiasbynens
Copy link
Member Author

During today’s TC39 meeting, the remaining editors signed off on the current version, and we reached consensus for Stage 3 — all of that conditional on us addressing the remaining feedback from @gibson042’s review (which we aim to do as soon as possible). PR: #56

@michaelficarra
Copy link
Member

@mathiasbynens To clarify, we said we were okay with it advancing to stage 3 without full editor reviews. This doesn't mean the PR will not require any further editorial changes before stage 4, it just means that we are confident we will be able to make them.

@mathiasbynens
Copy link
Member Author

@michaelficarra Ack. We’re happy to address any further feedback. Thanks!

mathiasbynens added a commit that referenced this issue Mar 29, 2022
@markusicu
Copy link
Collaborator

During today’s TC39 meeting, the remaining editors signed off on the current version, and we reached consensus for Stage 3 — all of that conditional on us addressing the remaining feedback from @gibson042’s review (which we aim to do as soon as possible).

I believe that I am addressing the last of @gibson042's review comments in mathiasbynens/ecma262#14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants