Remove with from the proposal #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rricard
requested review from
rickbutton,
robpalme,
littledan and
pipobscure
chicoxyzzy
reviewed
Sep 9, 2019
Co-Authored-By: Sergey Rubanov <[email protected]>
|
@robpalme I just added the .pop()/.push()/.with() examples that needed to be covered with the |
littledan
approved these changes
Sep 10, 2019
mheiber
approved these changes
Sep 10, 2019
|
After merging, we could close: and redirect the feedback on those issues to wherever the new proposal lives |
rickbutton
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still contestable at that point but we are edging to removing the
withpart of the proposal to make it easier to reason with for the time being. As a followup, we should have an orthogonal proposal that would introduce that feature everywhere in the language (not only for const value types)