Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

property name of "TrailingZeroDisplay" should be "trailingZeroDisplay" and the question about the default #42

Closed
FrankYFTang opened this issue Jun 18, 2021 · 0 comments · Fixed by #62
Closed

property name of "TrailingZeroDisplay" should be "trailingZeroDisplay" and the question about the default #42

FrankYFTang opened this issue Jun 18, 2021 · 0 comments · Fixed by #62
Labels
bug Something isn't working

Comments

@FrankYFTang
Copy link
Contributor

https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/diff.html#sec-initializenumberformat
Let trailingZeroDisplay be ? GetOption(options, "TrailingZeroDisplay", "string", « "auto", "stripIfInteger" », "stripIfInteger").

should be
Let trailingZeroDisplay be ? GetOption(options, "trailingZeroDisplay", "string", « "auto", "stripIfInteger" », "stripIfInteger").

also, is it intentional to switch the default to "stripIfInteger"? I cannot find the discussion of such change in #8 nor in https://github.com/tc39/proposal-intl-numberformat-v3
@sffc sffc added the bug Something isn't working label Jun 18, 2021
@chicoxyzzy chicoxyzzy mentioned this issue Jul 2, 2021
Closed
sffc added a commit that referenced this issue Jul 14, 2021
@sffc
Fix #42, trailingZeroDisplay.
43688a1
@sffc sffc mentioned this issue Jul 14, 2021
Merged
@sffc sffc closed this as completed in #62 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stage 3 review feedback tc39/proposal-intl-numberformat-v3
2 participants
@sffc @FrankYFTang