Use internal slot to store the stack trace #14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -41,6 +41,48 @@ markEffects: true | |||||
| </emu-table> | ||||||
| </emu-clause> | ||||||
|
|
||||||
| <emu-clause id="sec-well-known-intrinsic-objects"> | ||||||
| <h1>Well-Known Intrinsic Objects</h1> | ||||||
|
|
||||||
| <emu-table id="table-well-known-intrinsic-objects" caption="Well-Known Intrinsic Objects" oldids="table-7"> | ||||||
| <table> | ||||||
| <thead> | ||||||
| <tr> | ||||||
| <th> | ||||||
| Intrinsic Name | ||||||
| </th> | ||||||
| <th> | ||||||
| Global Name | ||||||
| </th> | ||||||
| <th> | ||||||
| ECMAScript Language Association | ||||||
| </th> | ||||||
| </tr> | ||||||
| </thead> | ||||||
| <tr> | ||||||
| <td> | ||||||
| %ErrorCaptureStackTraceGetter% | ||||||
| </td> | ||||||
| <td> | ||||||
| </td> | ||||||
| <td> | ||||||
| The getter installed by `Error.captureStackTrace` (<emu-xref href="#sec-error.capturestacktrace-getter"></emu-xref>) | ||||||
| </td> | ||||||
| </tr> | ||||||
| <tr> | ||||||
| <td> | ||||||
| %ErrorCaptureStackTraceSetter% | ||||||
| </td> | ||||||
| <td> | ||||||
| </td> | ||||||
| <td> | ||||||
| The setter installed by `Error.captureStackTrace` (<emu-xref href="#sec-error.capturestacktrace-setter"></emu-xref>) | ||||||
| </td> | ||||||
| </tr> | ||||||
| </table> | ||||||
| </emu-table> | ||||||
| </emu-clause> | ||||||
|
|
||||||
| <emu-clause id="sec-fundamental-objects" number="20"> | ||||||
| <h1>Fundamental Objects</h1> | ||||||
|
|
||||||
|
|
@@ -66,17 +108,31 @@ markEffects: true | |||||
| 1. Perform ? DefinePropertyOrThrow(_O_, *"stack"*, PropertyDescriptor { [[Value]]: _string_, [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: true }). | ||||||
| 1. Else, | ||||||
| 1. Assert: _strategy_ is ~accessor~. | ||||||
| 1. If ? IsExtensible(_O_) is *false*, throw a *TypeError* exception. | ||||||
| 1. Define a new [[ErrorStack]] internal slot on _O_. | ||||||
| 1. Perform ? DefinePropertyOrThrow(_O_, *"stack"*, PropertyDescriptor { [[Get]]: %ErrorCaptureStackTraceGetter%, [[Set]]: %ErrorCaptureStackTraceSetter%, [[Enumerable]]: false, [[Configurable]]: true }). | ||||||
|
Member
There was a problem hiding this comment. I just realized that the accessor is not enumerable where the data property is, any reason to have this difference?
Collaborator
Author
There was a problem hiding this comment. Thank you for catching that, the accessor is not enumerable in the V8 implementation: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/execution/messages.cc;l=1233;drc=6b98c207facca73446d15164ad3f9a62f4b41d11 and the data property is non-enumerable in SpiderMonkey/JSC: https://searchfox.org/firefox-main/rev/48f8a74041be2973d7df8ded3ad5e64c2c00e8dd/js/src/vm/ErrorObject.cpp#1082-1088. I'll fix the data property in the spec. |
||||||
| 1. Return *undefined*. | ||||||
| </emu-alg> | ||||||
| </emu-clause> | ||||||
| <emu-clause id="sec-error.capturestacktrace-getter"> | ||||||
| <h1>%ErrorCaptureStackTraceGetter% ( )</h1> | ||||||
| <p>The value of %ErrorCaptureStackTraceGetter% is a built-in function that takes no arguments. It performs the following steps when called:</p> | ||||||
|
Comment on lines
+118
to
+119
Member
There was a problem hiding this comment. I'm not sure how it works editorially, but I think we need to at least define the observable name of these accessors. |
||||||
| <emu-alg> | ||||||
| 1. Let _O_ be the *this* value. | ||||||
| 1. If _O_ has a [[StackTrace]] internal slot, then | ||||||
| 1. Return _O_.[[StackTrace]]. | ||||||
| 1. Else, | ||||||
| 1. Return *undefined*. | ||||||
| </emu-alg> | ||||||
| </emu-clause> | ||||||
| <emu-clause id="sec-error.capturestacktrace-setter"> | ||||||
| <h1>%ErrorCaptureStackTraceSetter% ( _value_ )</h1> | ||||||
| <p>The value of %ErrorCaptureStackTraceSetter% is a built-in function that takes an argument _value_. It performs the following steps when called:</p> | ||||||
| <emu-alg> | ||||||
| 1. Perform ? DefinePropertyOrThrow(*this* value, *"stack"*, PropertyDescriptor { [[Value]]: _value_, [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: true }). | ||||||
|
Member
There was a problem hiding this comment. As mentioned in #15:
Suggested change
Collaborator
Author
There was a problem hiding this comment. I missed this prior to merging, I'll address it in a follow up pr. |
||||||
| 1. Return *undefined*. | ||||||
| </emu-alg> | ||||||
| </emu-clause> | ||||||
| </emu-clause> | ||||||
| </emu-clause> | ||||||
| </emu-clause> | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match the
[[StackTrace]]used by the getter.I'm actually surprised we don't have a table of internal slots defined by the spec.