Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async callbacks #4

Closed
zloirock opened this issue Sep 1, 2021 · 2 comments
Closed

Async callbacks #4

zloirock opened this issue Sep 1, 2021 · 2 comments

Comments

@zloirock
Copy link
Contributor

zloirock commented Sep 1, 2021

Now, in the spec draft we have:

Снимок экрана 2021-09-01 в 14 04 01

However, in related methods of iterator helpers proposal, we await the result of the mapper:

Снимок экрана 2021-09-01 в 14 05 19

It should be consistent.

@js-choi
Copy link
Collaborator

js-choi commented Sep 1, 2021

Thank you for catching this; this is a good point.

I agree that the mapper function should be considered as an async function and its results should be awaited, in order to match iterator-helpers’ behavior. I will change this later if there are no objections from anyone else. CC: @codehag

js-choi added a commit that referenced this issue Sep 2, 2021
@js-choi
Copy link
Collaborator

js-choi commented Sep 2, 2021

The spec and explainer have been updated in 15ed9ce.

@js-choi js-choi closed this as completed Sep 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants