Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Update Table 4 Numbering systems #438

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Conversation

FrankYFTang
Copy link
Contributor

Add more numbering systems which on CLDR 37

Close #437

Add more numbering systems which on CLDR 37
@sffc sffc requested a review from litherum May 15, 2020 21:54
@sffc
Copy link
Contributor

sffc commented May 15, 2020

Would be good to get sign-off from the browser vendors.

@jswalden @litherum

@FrankYFTang
Copy link
Contributor Author

FrankYFTang commented May 16, 2020

@rkirsling - Could you comment about this since you are working on JSC .

@FrankYFTang
Copy link
Contributor Author

The list I proposed here (except "diak" and "segment") are ALREADY supported by two browser engines already:

  • Safari version 13.1
  • Chrome / v8 m81

"diak" and "segment" are new in CLDR / ICU and Chrome will support them in m84 with the update to ICU 67.1 .

@rkirsling
Copy link
Member

rkirsling commented May 16, 2020

Sounds good to me. JSC is aiming to defer to ICU / CLDR directly as much as possible, even if our pace of updating is slower than than V8's (...on most platforms, due to reliance on system ICU).

@leobalter
Copy link
Member

Let's bring this up for the meeting this week.

@leobalter leobalter added the s: discuss Status: TG2 must discuss to move forward label May 18, 2020
@sffc sffc added the has consensus Has consensus from TC39-TG2 label May 21, 2020
@sffc
Copy link
Contributor

sffc commented May 27, 2020

This has ECMA-402 consensus. We would like to see a more regular process of updating this list, but that doesn't block the current PR. We need to achieve TC39 consensus before it can be merged.

@anba
Copy link
Contributor

anba commented May 27, 2020

So we don't expect any compatibility issues with other software (#437 (comment))?

spec/numberformat.html Outdated Show resolved Hide resolved
@sffc
Copy link
Contributor

sffc commented May 30, 2020

Is this PR considered editorial or normative? Is it normative because conforming implementations could become non-conforming based on this PR, or is it editorial because it reflects web reality?

@FrankYFTang
Copy link
Contributor Author

Is this PR considered editorial or normative? Is it normative because conforming implementations could become non-conforming based on this PR, or is it editorial because it reflects web reality?

It is normative because https://ecma-international.org/ecma-402/#sec-partitionnumberpattern stated in step 8.e.iii.3
"If the numberFormat.[[NumberingSystem]] matches one of the values in the "Numbering System" column of Table 3 below, then"

@FrankYFTang
Copy link
Contributor Author

So.. TC39 reach consensus this morning. @sffc @leobalter @gibson042 could you approve?

@leobalter leobalter merged commit c8591d9 into master Jun 1, 2020
@leobalter leobalter deleted the FrankYFTang-patch-4 branch June 1, 2020 22:38
@sffc sffc changed the title Update Table 4 Numbering systems Normative: Update Table 4 Numbering systems Jun 2, 2020
anba added a commit to anba/test262 that referenced this pull request Jun 24, 2020
rwaldron pushed a commit to tc39/test262 that referenced this pull request Jun 24, 2020
@sffc sffc mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus Has consensus from TC39-TG2 s: discuss Status: TG2 must discuss to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Table 4: Numbering systems with simple digit mappings
5 participants