Normative: Make @@toStringTag values more meaningful #430
Conversation
|
This seems fine to me in theory, but the main question is if implementers will implement it. |
|
V8, JSC, and SpiderMonkey follow the current spec (except I am sure that with a few failing tests that are easy to fix, implementations will come. |
|
Thanks for this; I think browsers will implement it. I added it to the agenda to discuss at the next TG2 call, and then we can have it approved at the June TC39. |
|
I'm in favor of this; I bet it'll be web-compatible, but we could roll it back if needed. |
sffc
added
c: meta
|
@shvaikalesh I believe this will be well accepted. It would be very helpful if you could add the respective coverage in Test262. This way we have a good status of matching conformance and perhaps a vision of (non) breaking challenges. |
sffc
added
has consensus
|
We need to update the following test262 tests right after we land this PR intl402/Collator/instance-class.js |
|
@FrankYFTang Thank you for extensive list, I will make sure to update them all in tc39/test262#2634. |
|
FYI - bug for v8 to sync with this PR https://bugs.chromium.org/p/v8/issues/detail?id=10554 |
There was a problem hiding this comment.
LGTM!
Is this a thing we want to document in Annex B - Additions and Changes That Introduce Incompatibilities with Prior Editions?
yes, we need to add that. @shvaikalesh would you mind adding it? |
|
TC39 reach consensus this morning. |
Implement the spec changes in tc39/ecma402#430 Bug: v8:10554 Change-Id: I421d6feb94810027cf17ff58a4ec5357940ef44a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2212889 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#68119}
…tructor name. r=jwalden Implement the changes from <tc39/ecma402#430>. Differential Revision: https://phabricator.services.mozilla.com/D78035
…tructor name. r=jwalden Implement the changes from <tc39/ecma402#430>. Differential Revision: https://phabricator.services.mozilla.com/D78035
https://bugs.webkit.org/show_bug.cgi?id=212769 Reviewed by Yusuke Suzuki. JSTests: * test262/expectations.yaml: Mark 16 test cases as passing. * stress/intl-collator.js: * stress/intl-datetimeformat.js: * stress/intl-numberformat.js: * stress/intl-pluralrules.js: Update stress tests. Source/JavaScriptCore: Implementation of tc39/ecma402#430, which achieved consensus this week. This ensures we get "[object Intl.Collator]" (etc.) instead "[object Object]" for older Intl classes. * runtime/IntlCollatorPrototype.cpp: * runtime/IntlDateTimeFormatPrototype.cpp: * runtime/IntlNumberFormatPrototype.cpp: * runtime/IntlPluralRulesPrototype.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@262568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=212769 Reviewed by Yusuke Suzuki. JSTests: * test262/expectations.yaml: Mark 16 test cases as passing. * stress/intl-collator.js: * stress/intl-datetimeformat.js: * stress/intl-numberformat.js: * stress/intl-pluralrules.js: Update stress tests. Source/JavaScriptCore: Implementation of tc39/ecma402#430, which achieved consensus this week. This ensures we get "[object Intl.Collator]" (etc.) instead "[object Object]" for older Intl classes. * runtime/IntlCollatorPrototype.cpp: * runtime/IntlDateTimeFormatPrototype.cpp: * runtime/IntlNumberFormatPrototype.cpp: * runtime/IntlPluralRulesPrototype.cpp: Canonical link: https://commits.webkit.org/225582@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Resolves #176.
If this reaches consensus, I will proceed with
test262coverage and WebKit implementation.cc @littledan @Ms2ger