Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Normative: Change the hourCycle default logic (#758)
While hour12 is either true or false, let hourCycle to be either 'h12' or 'h23' but not 'h11' nor 'h24'. The current logic is not reasonable. We see no region in the CLDR use h11 nor h24 hour cycle as default. While we set a hour12: true on a 24 hour system region (which use 0:00 - 23:59), we should set to h12 instead of h11 Do not perform the starnge logic of setting default hourCycle based on both hour12 and the defaultHourCycle while hour12 is true or false. Instead, only depends on hour12 to set it to h12 or h23. Address #402 Co-authored-by: Shane F. Carr <[email protected]> Co-authored-by: Ujjwal Sharma <[email protected]> Co-authored-by: André Bargull <[email protected]>
- Loading branch information