Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Explicitly define default value of 'internalSlotsList' in OrdinaryCreateFromConstructor #2379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Editorial: Explicitly define default value of 'internalSlotsList' in OrdinaryCreateFromConstructor #2379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10569,6 +10569,7 @@ <h1>OrdinaryCreateFromConstructor ( _constructor_, _intrinsicDefaultProto_ [ , _
<emu-alg>
1. Assert: _intrinsicDefaultProto_ is a String value that is this specification's name of an intrinsic object. The corresponding object must be an intrinsic that is intended to be used as the [[Prototype]] value of an object.
1. Let _proto_ be ? GetPrototypeFromConstructor(_constructor_, _intrinsicDefaultProto_).
1. If _internalSlotsList_ is not present, set _internalSlotsList_ to a new empty List.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prose for this AO already says “ If internalSlotsList is not provided, a new empty List is used.”.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that's true, I think it's nicer to have it in the algorithm steps as well. There's a few other places we do this, like in Abstract Relational Comparison, and I think we should change all of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, should it be removed from the prose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to keep it in the prose as well - it's an accurate and potentially useful description of the behavior of the algorithm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you expect, then, that it'd be duplicated in prose and an algorithm step in every case where there's a default value on an optional AO argument?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the preambles are just general descriptions of the behavior; they don't need to all give exactly the same level of details.

1. Return ! OrdinaryObjectCreate(_proto_, _internalSlotsList_).
</emu-alg>
</emu-clause>
Expand Down