use offsetWidth and offsetHeight to handle zooming

[milomg]

previously if the node was created in a zoomed container, it would be incorrectly sized

[tbo47]

@aloisklink @sidharthv96 any opinion on this?

[JeanMeche]

Fwiw we're using that change successfuly in the Angular Devtools.

https://github.com/angular/angular/blob/c3e82fb2d511c99b7ff2f68513adc9ecebaa5246/tools/pnpm-patches/dagre-d3-es%2B7.0.11.patch#L1-L15

[aloisklink]

@aloisklink any opinion on this?

Unfortunately, I've never use dagre's rendering before (and mermaid doesn't use it either so I can't test this change with that), and this isn't anything I'm familiar with.

From what I'm reading in https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Determining_the_dimensions_of_elements, I'm a bit worried that this might cause a breaking change if somebody sets labelStyle with transform: scale(0.5);. But then, that seems unlikely and it sounds like many people have issues with zoom and dagre-d3, see dagrejs/dagre-d3#227, dagrejs/dagre-d3#251, dagrejs/dagre#259, dagrejs/dagre-d3#336 🤷

IMO, maybe it's worth merging this and releasing it, and we can always revert it if anybody complains about the new behaviour.

[JeanMeche]

Let's go then ?