Skip to content

Add a basic eslint linter config, and fixes some bugs that it caught #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbo47 merged 4 commits into from
Dec 14, 2022
Merged

Add a basic eslint linter config, and fixes some bugs that it caught #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d3a2fa
style: add a basic eslint linting action
aloisklink Dec 14, 2022
cbccb4f
fix: fix bug in setCreateEdgeLabels
aloisklink Dec 14, 2022
9ea4eae
style: lint with eslint-plugin-import
aloisklink Dec 14, 2022
d1475ad
fix: add `.js` or `index.js` to ESM imports
aloisklink Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
module.exports = {
env: {
browser: true,
es6: true, // todo, increase this es2016 or later to use new Javascript features
Copy link
Copy Markdown
Owner

@tbo47 tbo47 Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we use es2021. What do you use in marmaid-js?

Copy link
Copy Markdown
Owner

@tbo47 tbo47 Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13

node: true,
},
extends: ['eslint:recommended', 'plugin:import/recommended'],
overrides: [],
parserOptions: {
sourceType: 'module',
},
rules: {
// make sure that all files have an extension (required by ESM)
'import/extensions': [
'error',
'always',
{
js: 'always',
jsx: 'never',
mjs: 'always',
},
],
},
};
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci # throws an error if the package-lock.json file is out of sync
- name: Check for linting errors (run `npm run lint:fix` to fix)
run: npm run lint
- name: Check for prettier errors (run `npm run format` to fix)
run: npx prettier --check .
Loading