Make hoymiles library usable for other architectures #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rser.cpp to avoid compiler warnings f
…nctions from hardware
…ch didn't have the FunctionalInterrupt-implementation. This should be okay as we support only one Radio.
greenflash1986
force-pushed
the
prepareMultiPlatform
branch
from
156cddd to
54786f1
Compare
|
Updated base to current master. Best regards |
|
@greenflash1986 thanks for your efforts. Given that OpenDTU is targeted for the ESP32 architecture/platform only at the moment, not even ESP8266, I do not see this PR going anywhere soon. Though it may serve as an exercise for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tbnobody first of all thanks for the great work.
After I were unable to log my supply from my inverter with the Voltcraft plug, I stumpled accross the thread on Mikrocontroller. The work done there is very appreciated and although I'm unable to remember all the posts I where able to find the two repositories.
Now I want to use my spare Atmega328PB for the logging and I found your repository with the library approach the most promising. Although I don't know if the Atmega has enough speed or RAM (currently the Atmega-branch with only a simple main builds with >4kb and the Atmega only has 2kb) I already did some things to make the hoymiles library compile for the
atmelavr-toolchain.This PR is a request for comments: it's an idea to make things working for multiple platforms and maybe you want to change the library code in such a manner. I'm a software developer but my embedded skills and C++ knowledge is very limited. Therefore I would not assume that my code is correct in all details.
Please have a look and feel free to comment.
Best regards
GreenFlash1986