Fix: Auto reboot was not triggered on pin mapping change

tbnobody · Dec 14, 2024 · 5d14454 · 5d14454
1 parent 58382be
commit 5d14454
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/WebApi_device.cpp b/src/WebApi_device.cpp
@@ -129,10 +129,14 @@ void WebApiDeviceClass::onDeviceAdminPost(AsyncWebServerRequest* request)
         return;
     }
 
+    bool performRestart = false;
+
     {
         auto guard = Configuration.getWriteGuard();
         auto& config = guard.getConfig();
 
+        performRestart = root["curPin"]["name"].as<String>() != config.Dev_PinMapping;
+
         strlcpy(config.Dev_PinMapping, root["curPin"]["name"].as<String>().c_str(), sizeof(config.Dev_PinMapping));
         config.Display.Rotation = root["display"]["rotation"].as<uint8_t>();
         config.Display.PowerSafe = root["display"]["power_safe"].as<bool>();
@@ -149,7 +153,6 @@ void WebApiDeviceClass::onDeviceAdminPost(AsyncWebServerRequest* request)
     }
 
     auto const& config = Configuration.get();
-    bool performRestart = root["curPin"]["name"].as<String>() != config.Dev_PinMapping;
 
     Display.setDiagramMode(static_cast<DiagramMode_t>(config.Display.Diagram.Mode));
     Display.setOrientation(config.Display.Rotation);