Fix ReadError in AsyncTavilyClient during async concurrent requests and related modules #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes: - Replace `self._client_creator` with `self._client` to avoid crash in async.gather when setting up proxies in `proxy_mounts` Code refraction: - Removed unused imports and added better module export. - Improved exception handling specifying ImportError for cohere client in `hybrid_rag.py`. - Standardization of string quotes and formatting for enhanced code readability and consistency. - Updated Tavily Client constructor parameters to use Optional types for better type hinting. - Cleaned up code formatting and removed unnecessary comments for clarity.
Open
3 tasks
juchengquan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issues with proxy handling in the
AsyncTavilyClientclass by ensuring that proxies are correctly mapped and passed tohttpx.AsyncClient. The changes improve compatibility with custom proxy settings and environment variables.Relates to the issue #123.
Changes
Bug fixes:
__init__method ofAsyncTavilyClient:httpx.AsyncClientis now initialized with the correct proxy configuration usinghttpx.AsyncHTTPTransport.search,extract,crawl,map, etc.) remain compatible.Code refraction:
hybrid_rag.py.Checklist