Skip to content

Commit

Permalink
Add review guidelines
Browse files Browse the repository at this point in the history
Extends committee membership information with guidance on what is
expected of committee members.
  • Loading branch information
tautschnig committed Dec 12, 2024
1 parent 27a9931 commit 24a627f
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions doc/src/general-rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,18 @@ members = [
+ "rahulku"
]
```

Committee members are expected to contribute by reviewing pull requests (all
pull requests review approvals from at least two committee members before they
can be merged).
Reviews of solutions towards challenges should consider at least the following aspects:

1. Does the pull request implement a solution that respects/meets the success
criteria of the challenge?
2. Do the contracts and harnesses incorporate the safety conditions stated in
the documentation (from comments in the code and Rust book)? Note that we
currently focus on safety verification. Pre- and post-conditions towards
functional correctness are acceptable as long as they do not negatively
impact verification of safety, such as over-constraining input values.
3. Is the contributed code of adequate quality and idiomatic (to the best of the
committee member's knowledge).

0 comments on commit 24a627f

Please sign in to comment.