refactor(macos/ios): remove fullscreen and transparent feature flags - #1780
Merged
Conversation
Contributor
Package Changes Through bc00664There are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
commented
Jul 22, 2026
| if attributes.transparent || attributes.background_color.is_some() { | ||
| let no = NSNumber::numberWithBool(false); | ||
| { | ||
| if cfg!(target_os = "ios") || version.0 > 10 || (version.0 == 10 && version.1 >= 14) { |
Member
Author
There was a problem hiding this comment.
I never saw a crashlog (from that single user) that made the version check required here for macOS. None of the other kvc uses ever caused version specific crashes.
Contributor
There was a problem hiding this comment.
hmm.. let's give it a shot
FabianLars
marked this pull request as ready for review
July 22, 2026 12:31
pewsheen
reviewed
Jul 22, 2026
pewsheen
previously approved these changes
Jul 22, 2026
Legend-Master
added
platform: macOS
platform: iOS
type: breaking change
Legend-Master
approved these changes
Jul 27, 2026
Legend-Master
left a comment
Legend-Master
left a comment
Contributor
There was a problem hiding this comment.
Have no means to test this, just an approval on the idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sooo, looking around on the internet (eg stackoverflow), people have been using these on app store builds for ages, including a few in tauri land.
Speaking of Tauri land,
allowsPictureInPictureMediaPlaybackhas been unguarded since it was added and it did not cause issues.Note, that we can only assume app store compatibility for when we set property values like you can see in the diff (eg via
setValue_forKey) - actually using private objc apis will cause issues!!draft because done on windows and not tried on macos yettested on macos 12.4 and 26