fix(windows): infinite loop on handler error - #1680
Merged
Legend-Master merged 2 commits intoMar 4, 2026
Merged
Conversation
Contributor
Package Changes Through b6c598dThere are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Member
|
crazy that this wasn't noticed in 2 years |
Legend-Master
commented
Mar 4, 2026
Legend-Master
left a comment
Legend-Master
left a comment
Contributor
Author
There was a problem hiding this comment.
Guess we just assumed the hang was some sort of dead lock we had because of the re-entrant thing
chriscraws
pushed a commit
to chriscraws/wry
that referenced
this pull request
May 13, 2026
* fix(windows): infinite loop on handler error * Double clicked on the type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #1394
We need to send back the error instead of returning the error from the handler, not sure if there's a better way to write this though
Note: this is not a fix for the re-entrant hang #583 (comment)