refactor: replace kuchikiki with dom_query

[thomaseizinger]

The kuchikiki dependency has not been actively maintained in a while and pulls in a lot of old dependencies. We can replace fairly easily with the more maintained dom_query crate.

See tauri-apps/tauri#14958 for details.

[thomaseizinger]

I noticed that this code doesn't have any tests. Should we extract this into a non-Android gated module somewhere and write some tests that can run in CI?

[github-actions]

Package Changes Through a4347ba

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
wry	0.54.2	0.54.3

Add another change file through the GitHub UI by following this link.

---

Read about change files or the docs at github.com/jbolda/covector

[FabianLars]

thanks for the pr! much appreciated :) cargo update derive_more --precise 2.0.1 or something like that should fix CI error.

I noticed that this code doesn't have any tests. Should we extract this into a non-Android gated module somewhere and write some tests that can run in CI?

Sounds reasonable but it wouldn't be a blocker for me

[thomaseizinger]

thanks for the pr! much appreciated :) cargo update derive_more --precise 2.0.1 or something like that should fix CI error.

Done!

[thomaseizinger]

I noticed that this code doesn't have any tests. Should we extract this into a non-Android gated module somewhere and write some tests that can run in CI?

Sounds reasonable but it wouldn't be a blocker for me

I don't want to break anything so I'll see to write a test for this.

[Legend-Master]

I have not got the time to take a closer look yet, just from a quick browse, it seems like there's https://crates.io/crates/scraper which is much more popular, do we have any reason choosing dom_query over it?

Never mind, its main branch moved to edition 2024 last month which requires a MSRV bump

[FabianLars]

Never mind, its main branch moved to edition 2024 last month which requires a MSRV bump

wouldn't be a blocker imo. we're getting closer to edition 2024 by the day

[thomaseizinger]

I'd prefer merging something sooner and not blocking on an MSRV upgrade. Once the tests are in place, it should be easy to migrate though.

[Legend-Master]

Seems like the failed miri test is from servo/stylo#299

[Legend-Master]

Could you also add change file?

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	dom_query@​0.25.1

View full report

[thomaseizinger]

Could you also add change file?

Done!

[Legend-Master]

Thanks for the work and patience