Skip to content

feat: add WebView::set_cookie and WebView::delete_cookie - #1569

Merged
pewsheen merged 8 commits into
tauri-apps:devfrom
WSH032:feat/set-cookies
Jul 1, 2025
Merged

feat: add WebView::set_cookie and WebView::delete_cookie#1569
pewsheen merged 8 commits into
tauri-apps:devfrom
WSH032:feat/set-cookies

Conversation

@WSH032

@WSH032 WSH032 commented Jun 22, 2025

Copy link
Copy Markdown
Contributor

ref #1394
close #1511

@github-actions

github-actions Bot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 7cd795b

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.52.1 0.52.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@WSH032
WSH032 force-pushed the feat/set-cookies branch from cfae400 to af0c0fa Compare June 23, 2025 14:31
@WSH032
WSH032 marked this pull request as ready for review June 23, 2025 14:31
@WSH032
WSH032 requested a review from a team as a code owner June 23, 2025 14:31

@WSH032 WSH032 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already tested this on Windows and Linux. I need others to help test on macOS and iOS (since I don't have a Mac 😫).

I haven't implemented the Android part because I don't know Kotlin. I think this should be left for someone else to implement.

Comment thread src/wkwebview/mod.rs
@AlloryDante

Copy link
Copy Markdown

Thank you so much for making this. Once this gets approved I can finally build my app. I need this as my app needs to modify auth cookies for certain websites and this is the only way I can implement it. Thank you @WSH032 and @pewsheen

@pewsheen pewsheen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I currently could only reveiw the macOS part. Overall it looks good to me, but we'll need someone to review webview2 and gtk parts.

Also, I think you might missing the same site policy in macOS? If you're not able to implement that part then I can help with that.

Comment thread src/wkwebview/mod.rs Outdated
Comment thread src/wkwebview/mod.rs
Comment thread src/wkwebview/mod.rs Outdated
Comment thread examples/cookies.rs
@WSH032
WSH032 force-pushed the feat/set-cookies branch from af0c0fa to 64f5777 Compare July 1, 2025 11:33
@WSH032

WSH032 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Oops, I just re-signed my commit, so now I need to force push.

@pewsheen

pewsheen commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Oops, I just re-signed my commit, so now I need to force push.

Oh okay. If it's hard to rebase on your side, you can overwrite my commit and force push.

@WSH032
WSH032 force-pushed the feat/set-cookies branch from 883e466 to 7cd795b Compare July 1, 2025 15:24
@pewsheen
pewsheen merged commit 60dba38 into tauri-apps:dev Jul 1, 2025
@WSH032

WSH032 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Thanks!

@WSH032
WSH032 deleted the feat/set-cookies branch July 1, 2025 15:40
@AlloryDante

Copy link
Copy Markdown

OMG, thank you so much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Implement WebView::set_cookie

3 participants