feat(ios): add support for setting the background color - #1555
Merged
Conversation
Contributor
Package Changes Through e6016f7There are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
pewsheen
requested changes
May 15, 2025
| webview.setOpaque(false); | ||
|
|
||
| let color = objc2_ui_kit::UIColor::colorWithRed_green_blue_alpha( | ||
| (red / 255).into(), |
Contributor
There was a problem hiding this comment.
I think we should convert the value into a floating point like (red as f64 / 255.0) otherwise the value < 255 will present as 0.
Member
Author
There was a problem hiding this comment.
idk how i missed that, did i really only test colors that are close to 0 or 255 in all 3 colors? I mean, i'm colorblind but that's a bit wild 😂
pewsheen
previously approved these changes
May 16, 2025
pewsheen
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to get rid of white/black flashes on app launch. ref tauri-apps/tauri#1564