feat: macOS/iOS: add option to disable or enable link previews when building a webview - #1534
Merged
Merged
Conversation
…g a webview (the webkit api has it enabled by default) - `WebViewBuilderExtDarwin.allow_link_preview(allow_link_preview: bool)`
Simon-Laux
changed the title
3 tasks
pewsheen
reviewed
Apr 1, 2025
| /// Default is true. | ||
| /// | ||
| /// See https://docs.rs/objc2-web-kit/latest/objc2_web_kit/struct.WKWebView.html#method.allowsLinkPreview | ||
| fn allow_link_preview(self, allow_link_preview: bool) -> Self; |
Contributor
There was a problem hiding this comment.
Can we use with_link_preview to align with other builder method's naming style
lucasfernog
approved these changes
Apr 6, 2025
Contributor
Package Changes Through 1d5504cThere are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS/iOS: add option to disable or enable link previews when building a webview (the webkit api has it enabled by default)
WebViewBuilderExtDarwin.allow_link_preview(allow_link_preview: bool)I personally only need this to disable link previews, so I would be fine with setting a different default for tauri (like turning it off by default). Or even always disable it and don't expose api to change it.
.changesdirectory with the appropriate bump, see https://github.com/tauri-apps/wry/blob/dev/.changes/readme.mdcargo testpasses.