feat(cli): setup Android signing - #9964
Conversation
| val keystoreProperties = Properties() | ||
| try { | ||
| // release builds require the file to be set up | ||
| keystoreProperties.load(FileInputStream(rootProject.file("keystore.properties"))) | ||
| } catch (e: Exception) { | ||
| // load a dummy file for debug purposes (signing config won't be used) | ||
| keystoreProperties.load(FileInputStream(rootProject.file("keystore.properties.dummy"))) | ||
| } |
There was a problem hiding this comment.
maybe we should just include keystore.properties by default instead of the dummy one, or even just remove this altogether and just document how users might want to add signing later on if they wish.
There was a problem hiding this comment.
i'd be fine with this on docs instead @FabianLars @simonhyll
There was a problem hiding this comment.
It used to be in the docs but was lost in recent refactors of tauri documentation and whether we merge this PR or not, I think we will still need to have it documented
|
@FabianLars what do you think about this standard approach vs a documentation based one? I'd like to get this resolved asap.. |
|
I was going to PR the guide today, maybe I will do it tomorrow |
|
I really like the idea (though we should also document the manual approach) but maybe it makes more sense to match the other platforms where we rely on env vars (or maybe both)? |
|
I opened a PR for signing guide tauri-apps/tauri-docs#2337 anyways as it needs to be documented nonetheless |
in this case i think it's dangerous since we would end up writing secrets in plain text.. |
if we merge this PR we also need to update that guide btw |
|
another reason to merge this is that it helps people that do not commit the gen folder |
didn't we change that behavior? at least it should be fine to not ignore |
|
Yes, we changed it, but that doesn't mean that everyone will want to commit the folder if they don't intend on changing files in it (ignoring the context of this pr) |
|
by default we gitignore the gen folder IIRC |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/typescript@5.5.2 |
we don't, we only ignore |
|
the problem with this PR approach is it just as broken as if it wasn't configured, I would say even more broken, since without you can build your unsigned apk successfully but with this, it will always fail until signing is configured. |
Tweaks the default Android project to include a simple setup for Android signing.
Example Github Action usage: