Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler/windows): Update wix to fix vulnerabilities and add arm support #9861

Merged
merged 3 commits into from
May 29, 2024

Conversation

FabianLars
Copy link
Member

(careful, v1 branch!)

I won't be able to actually test this until Sunday but opening this for a community member to test (and for whoever else that wants to of course)

@FabianLars FabianLars requested a review from a team as a code owner May 23, 2024 20:40
@FabianLars FabianLars marked this pull request as draft May 23, 2024 20:42
lucasfernog
lucasfernog previously approved these changes May 24, 2024
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on UTM, works

@lucasfernog
Copy link
Member

is this one ready @FabianLars ?

@FabianLars
Copy link
Member Author

Change of plans and I wasn't home yet since I opened it. If you say it's working then I think it's good (check the change files and remove the bump one if you're not gonna release it quickly, we just wanted to match minors again).

Also not the biggest fan of the new folder but I guess that's the only way to make sure it gets the new one. Maybe we should use this versioning in general and add a tauri clean command idk

@FabianLars FabianLars marked this pull request as ready for review May 28, 2024 15:03
@FabianLars
Copy link
Member Author

With 9706(?) merged the bump changefile is useless, please remove it before merge (Idk if im dumb but deleting files is not working in the app for me)

@lucasfernog lucasfernog merged commit a020828 into 1.x May 29, 2024
12 checks passed
@lucasfernog lucasfernog deleted the feat/wix314 branch May 29, 2024 01:31
FabianLars added a commit that referenced this pull request Jun 17, 2024
amrbashir pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants