-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Backport RPM packaging to 1.x branch #9809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This time i'm quicker to review your PR 😅
Just a few minor things i could have added myself but since i'm waiting on #9796 (comment) we still have some time
…5202) * feat(bundler): Add RPM packaging * feat(bundler): Update 'rpm' to 0.13.1 * Fix fmt
@FabianLars : One of the CI tests is failing for me, but I think it is because I get the following diff on this branch atm after building, it seems unrelated to my change so I dont think I should integrate it?
|
We'll probably merge another pr before yours which will include this change. If you want to have green ci already you can just include this change. It's just some annoyance of our publishing pipeline :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test it yet because I'm still not home (send help pls) but considering it's a backport, seeing that CI is happy and with my comments being resolved I think this is good to go.
P.S. Big thanks for the contribution :) |
P.P.S. I swear I'll check your dmg backport when I'm back x) |
Thanks, I will rebase it tomorrow ready to go |
feat(bundler): Add RPM packaging, closes #4402 (#5202)
feat(bundler): Add RPM packaging
feat(bundler): Update 'rpm' to 0.13.1
Fix fmt
This is a backport of #5202 to the v1 branch