Skip to content

fix(core): allow !Sync futures to be used with #[command] - #1755

Merged
lucasfernog merged 1 commit into
devfrom
fix/not-sync-command-futures
May 9, 2021
Merged

fix(core): allow !Sync futures to be used with #[command]#1755
lucasfernog merged 1 commit into
devfrom
fix/not-sync-command-futures

Conversation

@chippers

@chippers chippers commented May 9, 2021

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This separates the autoref tag binding from executing the future so that rust can figure out that it doesn't need to stay borrowed. this allows !Sync futures again.

@chippers
chippers requested a review from a team May 9, 2021 19:54
@lucasfernog
lucasfernog merged commit f190f11 into dev May 9, 2021
@lucasfernog
lucasfernog deleted the fix/not-sync-command-futures branch May 9, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants