fix: menu related commands can panic - #15860
Merged
Legend-Master merged 2 commits intoAug 11, 2026
Merged
Conversation
Contributor
|
Is there any value in having the test from #15691 ? |
sftse
approved these changes
Aug 11, 2026
Contributor
Author
it was an explicit panic before so don't think so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15686
Closes #15691
The
do_menu_itemrelies on tauri menu plugin internals so that it doesn't work on user land unless you try really hard, so I marked it as hidden properly.