fix(bundler): stop bundling xdg-open and xdg-utils - #15804
Conversation
Package Changes Through f9e8ec8There are 14 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-bundler with minor, tauri-build with minor, tauri-macos-sign with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor, @tauri-apps/api with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
The theory sounds good, have no means to test this though
|
This likely still has issues because we're not cleaning up the env vars im the Command calls but issues caused by that should get worse by this pr. I don't think linuxdeploy intercepts calls like the new appimage does so we'll have to fix this in the plugin instead but i'll double check |
2 participants
This rarely actually worked. xdg-open had a bunch of problems (see list below) but xdg-mime especially requires the host system to have xdg-mime / update-desktop-database or rather support for mime handling for this to properly work. In other words: there's no value in bundling them.
fixes #15430
fixes #10617
fixes #10078
fixes #6172 (or maybe not, that's too generic)
And yes this means that if the host system does not have these the relevant functionality breaks but this is not our problem to fix (though we could have a popup warning or something idk)