fix: menu regression from #15679

[lucasfernog]

No description provided.

[Legend-Master]

I just knew for a fact calling something in drop would break something 😂

[Legend-Master]

I wonder if we should move the menu creation after app.register_core_plugins()?; like we did for initializing tray icons? (we should probably still keep the try_state to keep it safe though)

tauri/crates/tauri/src/app.rs

Lines 2383 to 2396 in e9e88a7

	#[cfg(desktop)]
	if let Some(menu) = self.menu {
	let menu = menu(&app.handle)?;
	app
	.manager
	.menu
	.menus_stash_lock()
	.insert(menu.id().clone(), menu.clone());
	#[cfg(target_os = "macos")]
	init_app_menu(&menu)?;
	app.manager.menu.menu_lock().replace(menu);
	}

[Legend-Master]

Suggested change

	// the `Builder::menu` closure runs, so menus dropped before that have no channel to remove.
	// the `crate::Builder::menu` closure runs, so menus dropped before that have no channel to remove.

[github-actions]

Package Changes Through eb46b16

There are 14 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-bundler with minor, tauri-utils with minor, tauri-build with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor, @tauri-apps/api with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
@tauri-apps/api	2.11.1	2.12.0
tauri-utils	2.9.3	2.10.0
tauri-macos-sign	2.3.4	2.4.0
tauri-bundler	2.9.4	2.10.0
tauri-runtime	2.11.3	2.12.0
tauri-runtime-wry	2.11.4	2.12.0
tauri-codegen	2.6.3	2.7.0
tauri-macros	2.6.3	2.7.0
tauri-plugin	2.6.3	2.7.0
tauri-build	2.6.3	2.7.0
tauri	2.11.5	2.12.0
@tauri-apps/cli	2.11.4	2.12.0
tauri-cli	2.11.4	2.12.0
tauri-driver	2.0.6	2.1.0

Add another change file through the GitHub UI by following this link.

---

Read about change files or the docs at github.com/jbolda/covector

[sftse]

I wonder if we should move the menu creation after app.register_core_plugins()?; like we did for initializing tray icons? (we should probably still keep the try_state to keep it safe though)

tauri/crates/tauri/src/app.rs

Lines 2383 to 2396 in e9e88a7

	#[cfg(desktop)]
	if let Some(menu) = self.menu {
	let menu = menu(&app.handle)?;
	app
	.manager
	.menu
	.menus_stash_lock()
	.insert(menu.id().clone(), menu.clone());
	#[cfg(target_os = "macos")]
	init_app_menu(&menu)?;
	app.manager.menu.menu_lock().replace(menu);
	}

This is probably not the right conversation to unpack this, but I think the state management should be strictly split between user and Tauri state. State initialization order is a bit non-obvious, and could be made more type safe.

[Legend-Master]

I do think there's room for improvement, but not sure how, do you have some ideas (no rush though)?