fix(bundler): sanitize WiX binary identifiers (fix: #14681) - #15651
Merged
Legend-Master merged 3 commits intoJul 6, 2026
Conversation
Contributor
Package Changes Through 08216ccThere are 14 changes which include tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri with minor, tauri-build with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor, @tauri-apps/api with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
MSI bundling fails when an external binary resolves to a filename that starts with a digit, for example
externalBin = [bin/7za]resolving to7za.exeon Windows.WiX rejects that value when it is used as a
Component/@Id:Closes #14681.
What is the new behavior?
MSI binary component IDs are normalized as WiX identifiers before rendering the
.wxstemplate. Filenames keep their existing bundle path, but their WiX IDs now:-with__, and._when the first character is not a letter or_So
7za.exeis emitted as_7za.exefor WiX while still installing the binary as7za.exe.Does this PR introduce a breaking change?
No.
Other information
Validated with:
cargo test -p tauri-bundlercargo check -p tauri-bundlercargo clippy -p tauri-bundler --all-targets -- -D warningscargo fmt --package tauri-bundler -- --checkgit diff --checkexternalBin = [bin/7za]; WiXcandle.exeandlight.execompleted successfully and generated an MSI.