Skip to content

fix(bundler): make .desktop and .DirIcon relative symlinks - #15596

Merged
FabianLars merged 4 commits into
devfrom
fix/appimage-diricon
Jun 28, 2026
Merged

fix(bundler): make .desktop and .DirIcon relative symlinks#15596
FabianLars merged 4 commits into
devfrom
fix/appimage-diricon

Conversation

@FabianLars

Copy link
Copy Markdown
Member

fixes #15110

@FabianLars
FabianLars requested a review from a team as a code owner June 28, 2026 14:16
@github-actions

github-actions Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through d93befb

There are 3 changes which include tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.9.3 2.9.4
@tauri-apps/cli 2.11.3 2.11.4
tauri-cli 2.11.3 2.11.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Legend-Master
Legend-Master previously approved these changes Jun 28, 2026
Comment thread .changes/appimage-diricon.md
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Legend-Master
Legend-Master previously approved these changes Jun 28, 2026
Comment thread .changes/appimage-diricon.md Outdated
@FabianLars

Copy link
Copy Markdown
Member Author

@Legend-Master the dev branch is still free for patch releases right? Might as well release that quickly before the next minor.

@Legend-Master

Legend-Master commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Yes, but we probably will need to bump rust used in the test ci or it could be stuck on the android cross build (or maybe not, we could always yolo and see 🙃)

@FabianLars

Copy link
Copy Markdown
Member Author

ah true

@FabianLars
FabianLars merged commit 67ffa19 into dev Jun 28, 2026
17 checks passed
@FabianLars
FabianLars deleted the fix/appimage-diricon branch June 28, 2026 15:53
Proksima pushed a commit to Proksima/tauri that referenced this pull request Aug 5, 2026
…s#15596)

* fix(bundler): make .desktop and .DirIcon relative symlinks

* fmt

* Update .changes/appimage-diricon.md

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* Update .changes/appimage-diricon.md

---------

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
wesbillman pushed a commit to block/buzz that referenced this pull request Aug 7, 2026
## Summary
<!-- What does this change and why? -->

#3419 is a tauri bug (tauri-apps/tauri#15110),
which is already fixed in
tauri-apps/tauri#15596. All we need is bump the
@tauri-apps/cli version to include the bug fix.

```sh
pnpm update --filter ./desktop @tauri-apps/cli@2.11.4
```

This pr simply includes the changes after running the update command.

### Related issue
<!-- Fixes #1234, or N/A. Before opening: search existing issues/PRs for
duplicates — link the closest one, or say "none found". -->

fix #3419

close #3436. this pr supersedes it.


### Testing
<!-- How was this verified? UI change? Include before/after screenshots
(or a short recording). -->

build the appimage and check the symlink in the appimage using
`unsquashfs`.
```sh
$ unsquashfs -o 944632 -ll /tmp/buzz/desktop/src-tauri/target/release/bundle/appimage/Buzz_0.5.4_amd64.AppImage | grep -i dirIcon
lrwxrwxrwx root/root                 8 2026-08-04 21:54 squashfs-root/.DirIcon -> Buzz.png
```

Signed-off-by: Tsung-Han Yu <14802181+johan456789@users.noreply.github.com>
41fred pushed a commit to 41fred/buzz that referenced this pull request Aug 9, 2026
## Summary
<!-- What does this change and why? -->

block#3419 is a tauri bug (tauri-apps/tauri#15110),
which is already fixed in
tauri-apps/tauri#15596. All we need is bump the
@tauri-apps/cli version to include the bug fix.

```sh
pnpm update --filter ./desktop @tauri-apps/cli@2.11.4
```

This pr simply includes the changes after running the update command.

### Related issue
<!-- Fixes block#1234, or N/A. Before opening: search existing issues/PRs for
duplicates — link the closest one, or say "none found". -->

fix block#3419

close block#3436. this pr supersedes it.


### Testing
<!-- How was this verified? UI change? Include before/after screenshots
(or a short recording). -->

build the appimage and check the symlink in the appimage using
`unsquashfs`.
```sh
$ unsquashfs -o 944632 -ll /tmp/buzz/desktop/src-tauri/target/release/bundle/appimage/Buzz_0.5.4_amd64.AppImage | grep -i dirIcon
lrwxrwxrwx root/root                 8 2026-08-04 21:54 squashfs-root/.DirIcon -> Buzz.png
```

Signed-off-by: Tsung-Han Yu <14802181+johan456789@users.noreply.github.com>
bhargavms pushed a commit to EWA-Services/buzz that referenced this pull request Aug 18, 2026
## Summary
<!-- What does this change and why? -->

block#3419 is a tauri bug (tauri-apps/tauri#15110),
which is already fixed in
tauri-apps/tauri#15596. All we need is bump the
@tauri-apps/cli version to include the bug fix.

```sh
pnpm update --filter ./desktop @tauri-apps/cli@2.11.4
```

This pr simply includes the changes after running the update command.

### Related issue
<!-- Fixes block#1234, or N/A. Before opening: search existing issues/PRs for
duplicates — link the closest one, or say "none found". -->

fix block#3419

close block#3436. this pr supersedes it.

### Testing
<!-- How was this verified? UI change? Include before/after screenshots
(or a short recording). -->

build the appimage and check the symlink in the appimage using
`unsquashfs`.
```sh
$ unsquashfs -o 944632 -ll /tmp/buzz/desktop/src-tauri/target/release/bundle/appimage/Buzz_0.5.4_amd64.AppImage | grep -i dirIcon
lrwxrwxrwx root/root                 8 2026-08-04 21:54 squashfs-root/.DirIcon -> Buzz.png
```

Signed-off-by: Tsung-Han Yu <14802181+johan456789@users.noreply.github.com>
Signed-off-by: bhargavms <bhargav.m@ewa-services.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] AppImage .DirIcon and .desktop symlinks use absolute paths, break when mounted

2 participants