refactor: address MSRV todos - #15586
Conversation
previous MSRV change was introduced by #11205 to follow the ecosystem and keep our dependencies up to date we must update our MSRV currently our agreed standard is to keep MSRV to "latest - 3", which currently is 1.83
Package Changes Through 8984ab3There are 12 changes which include tauri-utils with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-build with minor, tauri-cli with minor, tauri-macos-sign with minor, tauri-bundler with minor, tauri-driver with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
a028dae to
7aee40d
Compare
| let bin_path = app_settings.app_binary_path(&options, tauri_dir)?; | ||
|
|
||
| if !std::env::var_os("STATIC_VCRUNTIME").is_some_and(|v| v == "false") { | ||
| if std::env::var_os("STATIC_VCRUNTIME").is_none_or(|v| v != "false") { |
There was a problem hiding this comment.
This transformation is correct but the code was probably wrong to begin with; if STATIC_VCRUNTIME == true it will overwrite it with true. Probably wants is_none_or(|v| v != "true")
There was a problem hiding this comment.
Looks like it, we can do it in another PR that this PR would only contain refactors without behavior changes
|
Ok, so new CVE ha https://rustsec.org/advisories/RUSTSEC-2026-0194.html, |
* Update time * Clippy and address MSRV todo comments * Suppress RUSTSEC-2026-0194 * Ok, there're 2 quick-xml CVEs
4 participants
Fix #15608