Skip to content

enhance: remove T: Send + Sync requirement from State<'r, T> - #15578

Merged
sftse merged 5 commits into
tauri-apps:devfrom
sftse:cleanup-state
Jul 6, 2026
Merged

enhance: remove T: Send + Sync requirement from State<'r, T>#15578
sftse merged 5 commits into
tauri-apps:devfrom
sftse:cleanup-state

Conversation

@sftse

@sftse sftse commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

#13257 isn't getting any majorities.

This includes just the removal of some unsafe blocks and a bit of cleanup.

@sftse
sftse requested a review from a team as a code owner June 23, 2026 11:14
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through a1664c1

There are 14 changes which include tauri with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-build with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor, @tauri-apps/api with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.11.1 2.12.0
tauri-utils 2.9.3 2.10.0
tauri-macos-sign 2.3.4 2.4.0
tauri-bundler 2.9.4 2.10.0
tauri-runtime 2.11.3 2.12.0
tauri-runtime-wry 2.11.4 2.12.0
tauri-codegen 2.6.3 2.7.0
tauri-macros 2.6.3 2.7.0
tauri-plugin 2.6.3 2.7.0
tauri-build 2.6.3 2.7.0
tauri 2.11.5 2.12.0
@tauri-apps/cli 2.11.4 2.12.0
tauri-cli 2.11.4 2.12.0
tauri-driver 2.0.6 2.1.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@sftse

sftse commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Something is broken about cross compilation.

@Legend-Master

Copy link
Copy Markdown
Contributor

Something is broken about cross compilation.

Yeah, let's ignore that for now, see #15573 (comment)

Comment thread crates/tauri/src/state.rs
Comment thread crates/tauri/src/state.rs Outdated
Comment thread crates/tauri/src/state.rs Outdated
Comment thread crates/tauri/src/state.rs
@sftse
sftse force-pushed the cleanup-state branch 2 times, most recently from 10be6d8 to 6fb7edc Compare June 25, 2026 09:15

@Legend-Master Legend-Master left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a change file never mind, stale review comment

Comment thread crates/tauri/src/state.rs
@sftse
sftse requested a review from Legend-Master June 29, 2026 15:23
Comment thread .changes/change-pr-15578.md Outdated
Comment thread .changes/change-pr-15578.md
@Legend-Master Legend-Master added this to the 2.12 milestone Jul 2, 2026
@Legend-Master Legend-Master added the status: waiting Waiting on author label Jul 5, 2026
@Legend-Master Legend-Master removed the status: waiting Waiting on author label Jul 6, 2026
@Legend-Master Legend-Master changed the title Cleanup state enhance: remove T: Send + Sync requirement from State<'r, T> Jul 6, 2026
@sftse
sftse merged commit d3108ff into tauri-apps:dev Jul 6, 2026
19 checks passed
@sftse
sftse deleted the cleanup-state branch July 6, 2026 14:09
Proksima pushed a commit to Proksima/tauri that referenced this pull request Aug 5, 2026
…ri-apps#15578)

* remove needless pinning

* less unsafe

* reduce use of potentially dangerous fn inner() and replace with fn deref() where possible

* refactor(tauri): remove unnecessary trait bounds

* Add change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants