fix: points android videos dir to ExternalStorage movies directory (#15562) - #15563
Conversation
Package Changes Through 5676965There are 14 changes which include tauri with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-build with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor, @tauri-apps/api with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Thanks for this @onehumandev! The fix looks good and I agree it's the right direction— A few things to address before we merge:
Any thoughts @FabianLars @lucasfernog? |
…5562) This brings in the fix to point the movies directory on android to the correct path.
fb71614 to
6a06bd2
Compare
Good call; updated with recommendations. |
|
none other from what you said. i would have been fine with a |
Legend-Master
left a comment
There was a problem hiding this comment.
Normally we should not do this type of breaking changes in minor bumps, but it was a bit too broken before I guess this is fine
…5562) (tauri-apps#15563) This brings in the fix to point the movies directory on android to the correct path.
Summary
Fixes #15562: on Android, PathResolver::video_dir() / $VIDEO pointed at externalCacheDir instead of app-specific Movies storage.
PathPlugin.getVideoDirusedactivity.externalCacheDir, same location as $CACHE via getExternalCacheDir.Other media helpers (
getAudioDir,getPictureDir,getDocumentDir,getDownloadDir) already useactivity.getExternalFilesDir(Environment.DIRECTORY_*).Change getVideoDir to:
Why it matters
Wrong directory — cache is ephemeral; $VIDEO should not alias $CACHE.
FS scope broken — apps saving videos under Movies could not grant access via $VIDEO / $VIDEO/** because scope resolved to cache, not Movies.
Rust unchanged — PathResolver::video_dir() on Android still calls getVideoDir; only Kotlin resolution fixed.
Breaking change
$VIDEO / video_dir() on Android moves from external cache → app-specific Movies. Apps that wrote videos via the old $VIDEO path may need migration or path updates.
Test plan