Use workspace dependency management - #15412
Conversation
|
I was just about to ping @jbolda to ask whether covector supports this but CI already answered my question 😂 |
|
I do like this approach though so maybe we can fix covector |
|
Any plan for workspace lint rules? |
Package Changes Through 3cc97b6There are 14 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-build with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor, @tauri-apps/api with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
@Tunglies Not yet, you can open an issue on which lint rules do you want to enable and we can discuss there
@FabianLars I couldn't remember what was the problem back then, it seems to work at least in this run https://github.com/tauri-apps/tauri/actions/runs/28021124759/job/82937404412?pr=15412 |
Legend-Master
left a comment
There was a problem hiding this comment.
I like this a lot, but we probably need to fix the feature flags first since some of them actually depends on the default features
|
This was the error https://github.com/tauri-apps/tauri/actions/runs/26026811997/job/76506308250 - i think it still does not work but there are no subcrate (eg tauri-utils instead of tauri) changefiles anymore so it doesn't check. |
Can you explain? Just seen I missed a spot or two that are using their own paths instead of the workspace deps. |
Legend-Master
left a comment
There was a problem hiding this comment.
pretty much every example basically
|
Following up here as we had conversations on other mediums. Working through this support in |
|
covector 0.13 was released so we can try this again |
This reverts commit 5c15412.
|
I seem to get some errors running
|
sftse
left a comment
There was a problem hiding this comment.
What was the issue with cargo publish ?
I don't quite understand it yet, see the error in my comment above |
Resolved in b692576, pretty weird not gonna lie |
|
@jbolda do you know if we can dry run this to test how it does with covector? |
|
@Legend-Master Yea, run it locally with |
|
They seem to work for me locally, thanks! @jbolda |
|
@Legend-Master |
We can simplify dependency management a bit by centralizing the workspace-internal dependencies.