enhance: include permission identifier in ACL error messages

[MavenRain]

What kind of change does this PR introduce?

Enhancement to ACL error diagnostics.

Description

Closes #11262 (level 2 of the three-tier ask: identify the file and clarify
which identifier is invalid).

• Adds three path-attached variants to the ACL Error enum (TomlFile,
  JsonFile, Json5File) carrying the parse error and the file path. The
  legacy Toml, Json, Json5 variants stay for non-file parse contexts.
• Updates the parse call sites in acl/build.rs (3) and acl/capability.rs
  (3) to use the new variants via map_err, so the file path is reported in the
  error.
• Changes ParseIdentifierError::InvalidFormat from a unit variant to
  InvalidFormat(String) carrying the offending identifier. Updates the message
  to say "invalid plugin or permission identifier '': ..." rather than
  the previous generic "identifiers can only include ...".

The composite effect on the user-facing error (the exact scenario from
#11262):

Before: failed to parse JSON: identifiers can only include lowercase ASCII, hyphens which are not leading or trailing, and a single colon if using a prefix at line 16 column 23

After: failed to parse JSON file '/path/to/permissions/default.toml': invalid plugin or permission identifier 'sqlite_proxy:allow-foo': identifiers can only include lowercase ASCII letters, digits, hyphens (not leading or trailing), and a single colon when using a prefix at line 16 column 23

Notes for review

• The InvalidFormat variant signature change is technically a breaking API
  change. I verified there are zero in-tree pattern matches on
  ParseIdentifierError variants (grep -rn 'ParseIdentifierError::' crates/),
  so no internal callers break. External pattern matchers (if any) would need
  to update from InvalidFormat to InvalidFormat(_). The covector changeset
  is minor:enhance; happy to bump to major:breaking if you prefer.
• Level 1 of the issue (docs covering naming rules) was addressed separately
  at docs(plugins): document plugin and permission identifier syntax rules tauri-docs#3826.
• Level 3 (relaxing the underscore restriction) is a deeper change tied to
  serde_untagged (referenced in [feat] Better errors when deserializing capabilities #9951) and is intentionally out of scope here.

Build, test, fmt, clippy run locally on tauri-utils --features build,config-json5; all clean.

[github-actions]

Package Changes Through 7d65ead

There are 2 changes which include tauri-utils with patch, tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
tauri-utils	2.9.2	2.9.3
tauri-bundler	2.9.2	2.9.3
tauri-runtime	2.11.2	2.11.3
tauri-runtime-wry	2.11.2	2.11.3
tauri-codegen	2.6.2	2.6.3
tauri-macros	2.6.2	2.6.3
tauri-plugin	2.6.2	2.6.3
tauri-build	2.6.2	2.6.3
tauri	2.11.2	2.11.3
@tauri-apps/cli	2.11.2	2.11.3
tauri-cli	2.11.2	2.11.3

Add another change file through the GitHub UI by following this link.

---

Read about change files or the docs at github.com/jbolda/covector

[FabianLars]

This unfortunately is a breaking change and has to wait for v3

[MavenRain]

Thanks @FabianLars, I agreed. I just pushed a revision that keeps ParseIdentifierError::InvalidFormat as a unit variant (no API change) and instead wraps the offending value into the error at the Identifier::Deserialize boundary. The user-visible serde error message is unchanged in shape (invalid plugin or permission identifier '': ), so the diagnostic improvement carries through every real parse path (TOML/JSON/JSON5 capability and permission files) without breaking anyone matching on the enum. Direct callers of Identifier::try_from see the unit-variant Display as previously seen.

The three new path-attached parse variants (Error::TomlFile, Error::JsonFile, and Error::Json5File) are additive and remain in this PR; let me know if you want any of those split-out as well.

[Legend-Master]

Let's deprecate the old ones and add a todo for the removal in v3

[Legend-Master]

Actually.. We didn't mark this error type #[non_exhaustive] so adding a new type is also breaking...

Do you mind splitting the Identifier deserialization code to a new PR so we can merge it first? The error message change will probably need to wait for v3

[Legend-Master]

Could we align this with

tauri/crates/tauri-utils/src/config/parse.rs

Line 84 in 79e7ab8

FormatJson {

e.g.

    /// The path that failed to parse into JSON.
    path: PathBuf,

    /// The parsing [`serde_json::Error`].
    error: serde_json::Error,

(p.s. not the name, just tuple to struct)

[Legend-Master]

Thanks, awesome improvement!

Also you'll need to sign your commits for me to merge this

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits