Revert "fix(deps): update specta in lockfile" - #15305
Conversation
This reverts commit b240341.
Package Changes Through f181925There are 11 changes which include tauri with minor, @tauri-apps/api with minor, tauri-build with minor, tauri-macos-sign with patch, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
left a comment
FabianLars
left a comment
There was a problem hiding this comment.
i don't really get why we're reverting, so we can test the minimum version?
|
Basically just for the tests to run, the new specta requires some updates on the tests for clippy and requires edition 2024 which we can't use because of MSRV. I don't exactly know why #15177 tried to bumped it at the first place if the docs.rs build failure was not caused by the locked version, I just assumed it was a mistake the change was reverted in be7aabd. (also didn't notice the CI didn't run) |
Follow-up to the MSRV bump. With the toolchain raised, compilation gets further and uncovers more pre-existing breakage on this branch. Pin `specta` to 2.0.0-rc.20 in the lockfile, matching `dev`. rc.25 uses the unstable `debug_closure_helpers` feature and cannot build on stable, which broke `test tauri` on all three platforms. `dev` pins the same version for this reason (tauri-apps#15305). Fix two genuine breakages under `--all-features`: - `manager/webview.rs` called `tauri_utils::html2::parse`, which does not exist. The `html2` migration renamed it to `parse_doc` and made the document render via `Document::html()`; the merge in 69732d8 kept the old call. Restored to match `dev`. - the `check_get_url_cef` test omitted the macOS/iOS-gated `on_web_content_process_terminate` argument, so `with_handlers` was called with a shifted argument list on Apple targets. Matches `check_get_url_wry` now. The remaining changes are clippy lints reported by current stable, all of them mechanical and behaviour-preserving: `manual_filter`, `useless_borrows_in_formatting`, `let_and_return`, `redundant_closure`, `while_let_on_iterator` and `too_many_arguments`. Two lint fixes are in code CI does not lint (the clippy job runs on Linux only) but which fail `cargo clippy` locally on macOS: the dmg bundler and `cef/macos_dev.rs`. The `examples/api` CEF DevTools block is additionally gated on `not(test)`, since under `cfg(test)` the runtime is `MockRuntime`, which does not expose those methods. Verified in an ubuntu:24.04 container on rustc/clippy 1.97.1, matching the CI job: `cargo clippy --all-targets --all-features -- -D warnings` passes. `cargo +1.90 test --all-features --manifest-path crates/tauri/Cargo.toml` passes (67 lib + 123 doc tests).
2 participants
Reverts #15303
Looking at https://docs.rs/crate/tauri/latest/builds/2963776, it seems to be pulling in
specta-2.0.0-rc.23which is not in the lockfile 🤷♂️