fix(tauri-build): set Windows FileVersion/ProductVersion strings from tauri config - #15288
Conversation
Package Changes Through 84dd19bThere are 11 changes which include tauri with minor, @tauri-apps/api with minor, tauri-build with minor, tauri-macos-sign with patch, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Nice catch, thanks!
And just a bit of nitpicks. Also, I don't see anywhere we set these fields before #8168, could you verify this?
|
Thanks, updated the I also re-verified the history:
So the string setters were present before #8168 and were dropped there during the refactor. |
|
Not sure what's wrong with Let's update the change file and PR descriptions Also, you'll need to sign your commits for me to merge this |
655d831 to
6b1f47e
Compare
|
Updated:
|
6b1f47e to
f7ad0e3
Compare
f7ad0e3 to
0f8a218
Compare
|
Updated the branch again after the branch-protection experiment note. The no-op
The current PR head is a single signed commit on top of the latest |
|
We could revert, we were just experimenting with the branch protection rules |
0f8a218 to
84dd19b
Compare
Summary
This PR sets the Windows
FileVersionandProductVersionstring values fromconfig.versionintauri-build.The current
devbranch sets the numericFILEVERSION/PRODUCTVERSIONfixed fields from the Tauri config, but does not set the correspondingFileVersion/ProductVersionstring values. In that case those strings fall back to whatevertauri-winresinferred fromCargo.toml.That can leave the built
.exewith mixed version sources:FILEVERSION/PRODUCTVERSIONfixed fields come fromconfig.versionFileVersion/ProductVersionstrings come fromCargo.tomlThis PR restores the missing string setters so that Windows VERSIONINFO uses the version from the Tauri config consistently.
Why this is safe
tauri-buildchangelog entry that says these fields come fromtauri.conf.jsoncrates/tauri-build/src/lib.rstauri-winresCargo metadata overridesVerification
cargo build -p tauri-build.changesentry