Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .changes/change-pr-15175.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
"@tauri-apps/api": patch
"tauri-utils": patch
"tauri-macos-sign": patch
"tauri-bundler": patch
"tauri-runtime": patch
"tauri-runtime-wry": patch
"tauri-codegen": patch
"tauri-macros": patch
"tauri-plugin": patch
"tauri-build": patch
"tauri": patch
"@tauri-apps/cli": patch
"tauri-cli": patch
"tauri-driver": patch
Comment thread
Legend-Master marked this conversation as resolved.
Outdated
---

Italian language update
Comment thread
Legend-Master marked this conversation as resolved.
Outdated
4 changes: 2 additions & 2 deletions crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Var NoShortcutMode
Var WixMode
Var OldMainBinaryName

Name "${PRODUCTNAME}"
Name "${PRODUCTNAME} ${VERSION}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind if we add the version to the name but it seems like just the app name is the standard here?

https://nsis.sourceforge.io/Reference/Name

Anyways, let's don't touch on this in this PR of the Italian translation update

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legend-Master

Typically in this way you can see on top left after program name program version.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mp3tag use NSIS and show this info
image

@bovirus bovirus Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legend-Master
OpenVideoDownloader installer use tauri and NSIS script and don't show the version info
image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you enable you can see like this
image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the changes to installer.nsh

@Legend-Master Legend-Master Apr 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move and discuss these in a separate PR and merge the Italian translations first

BrandingText "${COPYRIGHT}"
OutFile "${OUTFILE}"

Expand All @@ -80,7 +80,7 @@ InstallDir "${PLACEHOLDER_INSTALL_DIR}"

VIProductVersion "${VERSIONWITHBUILD}"
VIAddVersionKey "ProductName" "${PRODUCTNAME}"
VIAddVersionKey "FileDescription" "${PRODUCTNAME}"
VIAddVersionKey "FileDescription" "${PRODUCTNAME} installer"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this probably shouldn't have been ${PRODUCTNAME} but an actual description of the app
Anyways, let's don't touch on this in this PR of the Italian translation update

@bovirus bovirus Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legend-Master

This the file description field content in exe file properties.
The standard if you don't setup is "${PRODUCTNAME}"
With this instruction you change in "${PRODUCTNAME} installer".
Because the exe is the installer not setup.
If you want I can open for installer.nsh a separate pull request.

@bovirus bovirus Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current with aturi and NSIS Product Name nd Product decsription are the same
image

@bovirus bovirus Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my proposal is like Mp3tag (product name and product description are different)
image

VIAddVersionKey "LegalCopyright" "${COPYRIGHT}"
VIAddVersionKey "FileVersion" "${VERSION}"
VIAddVersionKey "ProductVersion" "${VERSION}"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
LangString addOrReinstall ${LANG_ITALIAN} "Aggiungi/Reinstalla componenti"
LangString alreadyInstalled ${LANG_ITALIAN} "Già installato"
LangString alreadyInstalledLong ${LANG_ITALIAN} "${PRODUCTNAME} ${VERSION} è già installato. Seleziona l'operazione che vuoi eseguire e clicca Avanti per continuare."
LangString appRunning ${LANG_ITALIAN} "{{product_name}} è in esecuzione! Chiudi e poi riprova."
LangString appRunningOkKill ${LANG_ITALIAN} "{{product_name}} è in esecuzione!$\nSeleziona OK per chiuderlo"
LangString chooseMaintenanceOption ${LANG_ITALIAN} "Seleziona l'operazione di manutenzione da eseguire."
LangString choowHowToInstall ${LANG_ITALIAN} "Seleziona come vuoi installare ${PRODUCTNAME}."
LangString createDesktop ${LANG_ITALIAN} "Crea scorciatoia sul Desktop"
LangString addOrReinstall ${LANG_ITALIAN} "Aggiungi/reinstalla componenti"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I don't speak any Italian, but just looking by the patterns and a quick google translate to English, it seems to me that the old ones are more inline with the main ones we had in crates/tauri-bundler/src/bundle/windows/nsis/languages/English.nsh (e.g. Add/Reinstall components/Aggiungi/Reinstalla componenti)

@bovirus bovirus Apr 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legend-Master

I'm italian mothertongue and I'm working as official Italian translator for many sofwtares (ex. Inno Setup and NSIS and many others).
The first basic rule for Italian grammar is that in a string only first letter of a paragraph is in uppercase (except own names).
For a good translation the understanding of the context is another base rule.
I checked the strings and I can confirm that my Italian translation is better then original, follow the rules of Italian grammaer and are related to the context of the string.
The I confirm my request to merge that.

Please also remind the changes about installer.nsi file

; Add in each installer window on top left program version after program name
Name "${PRODUCTNAME} ${VERSION}"

; Replace in program description after program name "Setup" with "Installer" - ex. "Tauri installer"
VIAddVersionKey "FileDescription" "${PRODUCTNAME} installer"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently on my phone so I can't check the installer.nsi changes yet

Just want to ping @alex-sandri for a quick review since he wrote the original translation

@bovirus bovirus Apr 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legend-Master

Please check NSIS official Italian language strings.

The original tauri italian strings don't follow Italian grammar rules (see below for explanation), don't match with NSIS Italian language, and sometimes use term out of the standard for the specific context..

And don't follow the flow difference for the paragraph about English/Italian.

In English you use "Do something for specific action".
In Italian we use "For a specific action do something"

It's also important to check the context and the standard for term used in the specific context. Ex:

"Crea scorciatoia sul desktop" (tauri original)
"Crea collegamento sul desktop" (standard translation for Windows)

image

"Scaricando il bootstrapper WebView2..." (tauri original)
It's wrong and not Italian. The progressive verb in this mode is an Italian grammar error.
The right Italian grammatical mode is "Sto scaricando" but is not usual in software context.

"Download bootstrapper WebView2..." (right one)
"Download" is more common then "Scarica" and the article is not necessary

When an operation can be done with mouse or keyboard is more common to use "Seleziona" instead "Clicca". "Seleziona" is an universal term for this context.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I would still want to wait a bit for @alex-sandri since he wrote the original version

Will merge this if he didn't respond though

@bovirus bovirus Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legend-Master

Thanks.
I hope will apply the changes about installer.nsh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legend-Master sorry if I wasn't able to reply sooner but I was a little busy at work. Anyway the changes proposed by @bovirus look good to me except for one small thing I commented on (line 10).

LangString alreadyInstalled ${LANG_ITALIAN} "Programma già installato"
LangString alreadyInstalledLong ${LANG_ITALIAN} "${PRODUCTNAME} ${VERSION} è già installato.$\nPer continuare scegli l'operazione da eseguire e seleziona 'Avanti'."
LangString appRunning ${LANG_ITALIAN} "{{product_name}} è in esecuzione!$\nChiudi {product_name}} e riprova."
LangString appRunningOkKill ${LANG_ITALIAN} "{{product_name}} è in esecuzione!$\nPer chiudere {product_name} seleziona 'OK'"
LangString chooseMaintenanceOption ${LANG_ITALIAN} "Scegli l'operazione di manutenzione da eseguire."
LangString choowHowToInstall ${LANG_ITALIAN} "Scegli come vuoi installare ${PRODUCTNAME}."
LangString createDesktop ${LANG_ITALIAN} "Crea collegamento sul desktop"
LangString dontUninstall ${LANG_ITALIAN} "Non disinstallare"
LangString dontUninstallDowngrade ${LANG_ITALIAN} "Non disinstallare (Il downgrade senza la disinstallazione è disabilitato per questo installer)"
LangString failedToKillApp ${LANG_ITALIAN} "Impossibile chiudere {{product_name}}. Chiudi e poi riprova"
LangString installingWebview2 ${LANG_ITALIAN} "Installando WebView2..."
LangString newerVersionInstalled ${LANG_ITALIAN} "Una versione più recente di ${PRODUCTNAME} è già installata! Non è consigliato installare una versione più vecchia. Se vuoi comunque procedere, è meglio prima disinstallare la versione corrente. Seleziona l'operazione che vuoi eseguire e clicca Avanti per continuare."
LangString dontUninstallDowngrade ${LANG_ITALIAN} "Non disinstallare (per questo installer il downgrade senza la disinstallazione è disabilitato )"
Comment thread
Legend-Master marked this conversation as resolved.
Outdated
LangString failedToKillApp ${LANG_ITALIAN} "Impossibile chiudere {{product_name}}.$\nChiudi {product_name} e poi riprova"
LangString installingWebview2 ${LANG_ITALIAN} "Installazione WebView2..."
LangString newerVersionInstalled ${LANG_ITALIAN} "È già installata una versione più recente di ${PRODUCTNAME}!$\nNon è consigliato installare una versione più vecchia.$\nSe vuoi comunque procedere, è meglio prima disinstallare la versione attuale.$\nPer continuare scegli l'operazione da eseguire e seleziona 'Avanti'."
LangString older ${LANG_ITALIAN} "più vecchia"
LangString olderOrUnknownVersionInstalled ${LANG_ITALIAN} "Una versione $R4 di ${PRODUCTNAME} è installata nel tuo sistema. È consigliato che disinstalli la versione corrente prima di procedere all'installazione. Seleziona l'operazione che vuoi eseguire e clicca Avanti per continuare."
LangString silentDowngrades ${LANG_ITALIAN} "I downgrade sono disabilitati per questo installer, impossibile procedere con l'installer silenzioso, usa invece l'installer con interfaccia grafica.$\n"
LangString olderOrUnknownVersionInstalled ${LANG_ITALIAN} "Nel sistema è installata una versione $R4 di ${PRODUCTNAME}.$\nPrima di procedere all'installazione è consigliabile disinstallare la versione attuale.$\nPer continuare scegli l'operazione da eseguire e seleziona 'Avanti'."
LangString silentDowngrades ${LANG_ITALIAN} "Per questo installer i downgrade sono disabilitati , impossibile procedere con l'installer silenzioso, usa invece l'installer con interfaccia grafica.$\n"
LangString unableToUninstall ${LANG_ITALIAN} "Impossibile disinstallare!"
LangString uninstallApp ${LANG_ITALIAN} "Disinstalla ${PRODUCTNAME}"
LangString uninstallBeforeInstalling ${LANG_ITALIAN} "Disinstalla prima di installare"
LangString unknown ${LANG_ITALIAN} "sconosciuta"
LangString webview2AbortError ${LANG_ITALIAN} "Errore nell'installazione di WebView2! L'app non può funzionare senza. Prova a riavviare l'installer."
LangString webview2DownloadError ${LANG_ITALIAN} "Errore: Il download di WebView2 è fallito - $0"
LangString webview2DownloadSuccess ${LANG_ITALIAN} "Bootstrapper WebView2 scaricato con successo"
LangString webview2Downloading ${LANG_ITALIAN} "Scaricando il bootstrapper WebView2..."
LangString webview2InstallError ${LANG_ITALIAN} "Errore: L'installazione di WebView2 è fallita con il codice $1"
LangString webview2AbortError ${LANG_ITALIAN} "Errore nell'installazione di WebView2!$\nL'app non può funzionare senza.$\nProva a riavviare l'installer."
LangString webview2DownloadError ${LANG_ITALIAN} "Errore: il download di WebView2 è fallito - $0"
LangString webview2DownloadSuccess ${LANG_ITALIAN} "Download bootstrapper WebView2 completato"
LangString webview2Downloading ${LANG_ITALIAN} "Download bootstrapper WebView2..."
LangString webview2InstallError ${LANG_ITALIAN} "Errore: l'installazione di WebView2 è fallita con codice errore $1"
LangString webview2InstallSuccess ${LANG_ITALIAN} "WebView2 installato correttamente"
LangString deleteAppData ${LANG_ITALIAN} "Cancella i dati dell'applicazione"
Loading