refactor(macos-sign): use base64 crate instead of Command - #15038
Conversation
Package Changes Through 33fafa3There are 3 changes which include tauri-macos-sign with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Not sure if we need a change file?
| .map_err(|error| Error::CommandFailed { | ||
| command: "base64 --decode".to_string(), | ||
| // strip whitespace before decoding | ||
| let cleaned: String = input.chars().filter(|c| !c.is_ascii_whitespace()).collect(); |
There was a problem hiding this comment.
Not exactly sure the behavior with the OS base64, but I think we should add a bit more context here in the comments
There was a problem hiding this comment.
I don't have enough information about what was the previous problem exactly, so maybe @lucasfernog can shed some light on it
There was a problem hiding this comment.
this is just tech debt from the days David wrote this - like 5 years ago?? omg i'm old
33fafa3
…#15038) * refactor(macos-sign): use base64 crate instead of Command * add base64 crate as a dependency * add change file --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
…#15038) * refactor(macos-sign): use base64 crate instead of Command * add base64 crate as a dependency * add change file --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
4 participants
Avoids the mentioned issue by stripping whitespace before decoding.
This fixes a niche case for me, where I have base64 installed on macOS from GNU coreutils, which doesn't use the same flags and builds were failing for me.