Skip to content

chore(deps)!: replace json5 with serde_json5 - #14497

Closed
FabianLars wants to merge 2 commits into
devfrom
deps/json5
Closed

chore(deps)!: replace json5 with serde_json5#14497
FabianLars wants to merge 2 commits into
devfrom
deps/json5

Conversation

@FabianLars

Copy link
Copy Markdown
Member

closes #14494

strictly speaking this is a breaking change because we re-export the ConfigError from tauri-utils 😮‍💨 i won't merge this without approval

@FabianLars
FabianLars requested a review from a team as a code owner November 19, 2025 10:04
@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 873a233

There are 6 changes which include @tauri-apps/api with patch, tauri with patch, tauri-cli with patch, tauri-bundler with patch, @tauri-apps/cli with patch, tauri-macos-sign with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.9.0 2.9.1
tauri-macos-sign 2.3.0 2.3.1
tauri-bundler 2.7.3 2.7.4
tauri 2.9.3 2.9.4
@tauri-apps/cli 2.9.4 2.9.5
tauri-cli 2.9.4 2.9.5

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars FabianLars added the type: breaking change This issue or pull request will introduce a breaking change and requires major version bump label Nov 19, 2025
@Legend-Master

Copy link
Copy Markdown
Contributor

Feel like there'll be very few people actually use that error variant, update this in a minor bump feels ok to me

But since there're no major issues with the current json5 crate, I don't mind waiting for v3 either though

@FabianLars

Copy link
Copy Markdown
Member Author

json5 is maintained again so no need to switch to a fork of it that doesn't offer anything else.

@FabianLars FabianLars closed this Dec 3, 2025
@FabianLars
FabianLars deleted the deps/json5 branch December 3, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: breaking change This issue or pull request will introduce a breaking change and requires major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2025-0120: json5 crate is unmaintained

2 participants