fix(cli): avoid unwrap panic when resolving npm_execpath on Windows - #14476
Closed
sakina1303 wants to merge 1 commit into
Closed
fix(cli): avoid unwrap panic when resolving npm_execpath on Windows#14476sakina1303 wants to merge 1 commit into
sakina1303 wants to merge 1 commit into
Conversation
Author
|
@FabianLars Hi! Just wanted to check if this approach looks good to you, or if you’d like any adjustments. |
Member
|
first of all i'd like us to investigate the user's issue a bit since this is not a common occurrence (we have many bun users). Depending on the root cause your PR may not even fix it for them. Secondly, if we do need special handling for bun i'd prefer if it could look closer to the pnpm handling or the deno check rather than the extra stem check upfront. |
Contributor
".."
Based on the nonsensical description this is likely AI-generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic that occurred during tauri android init when npm_execpath pointed to a path where file_stem() returned None—a situation that happens on some Windows setups and when using Bun.
Previously, the code called:
If file_stem() returned None, the CLI crashed with an unwrap() panic.
What this PR changes-
This replaces the unsafe unwrap() with a safe fallback chain:
This ensures that the CLI never panics due to unexpected or non-standard npm/bun paths.
Why this is correct-
Verification-
Fixes #14472