Skip to content

fix: return error on window creation failed - #13970

Merged
Legend-Master merged 2 commits into
tauri-apps:devfrom
Legend-Master:return-error-on-window-creation-failed
Aug 9, 2025
Merged

fix: return error on window creation failed#13970
Legend-Master merged 2 commits into
tauri-apps:devfrom
Legend-Master:return-error-on-window-creation-failed

Conversation

@Legend-Master

Copy link
Copy Markdown
Contributor

Reference: #13969

Not sure if we could change the CreateWindow error varient to something like what we have for CreateWebview to include the actual error

  #[error("failed to create webview: {0}")]
  CreateWebview(Box<dyn std::error::Error + Send + Sync>),

I'm not entirely sure if this panic is intentional or not (I would assume not) and the git blame shows that it's from ages ago

@Legend-Master
Legend-Master requested a review from a team as a code owner August 9, 2025 09:31
@github-actions

github-actions Bot commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 6a6df33

There are 8 changes which include tauri-utils with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-bundler with patch, tauri-runtime-wry with patch, tauri with minor, @tauri-apps/api with minor, tauri-plugin with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.7.0 2.8.0
tauri-utils 2.6.0 2.7.0
tauri-bundler 2.5.2 2.5.3
tauri-runtime 2.7.1 2.7.2
tauri-runtime-wry 2.7.2 2.7.3
tauri-codegen 2.3.1 2.3.2
tauri-macros 2.3.2 2.3.3
tauri-plugin 2.3.1 2.4.0
tauri-build 2.3.1 2.3.2
tauri 2.7.0 2.8.0
@tauri-apps/cli 2.7.1 2.8.0
tauri-cli 2.7.1 2.8.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars

Copy link
Copy Markdown
Member

Not sure if we could change the CreateWindow error varient to something like what we have for CreateWebview to include the actual error

Modifying the existing variant would count as a breaking change i think? We could add a new variant but maybe just add a todo for v3 on the existing variant idk 🤷

I'm not entirely sure if this panic is intentional or not (I would assume not) and the git blame shows that it's from ages ago

Doesn't really matter if it is/was intention (to me at least), we should strive towards never panicking in our libs imo

@Legend-Master
Legend-Master merged commit 196ace3 into tauri-apps:dev Aug 9, 2025
27 checks passed
@Legend-Master
Legend-Master deleted the return-error-on-window-creation-failed branch August 9, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants