failed binary patch warning - #13825
Merged
Legend-Master merged 2 commits intoJul 14, 2025
Merged
Conversation
Contributor
Package Changes Through 4c24677There are 6 changes which include @tauri-apps/cli with patch, tauri-cli with minor, @tauri-apps/api with patch, tauri-bundler with patch, tauri with minor, tauri-utils with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
previously approved these changes
Jul 14, 2025
Legend-Master
left a comment
Contributor
There was a problem hiding this comment.
Thanks, just some suggestions around the wording
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Legend-Master
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agree in #13812 (comment) changing error to warning here.
Keep in mind that tests I added to updater-plugin will fail if the binary can't be patched correctly so there's still some verification for this feature in the pipeline.